Skip to content

fix(addie): enforce common fixed-trace tool universe - #7302

Merged
bokelley merged 4 commits into
mainfrom
conductor/addie-common-eval-tool-universe
Sep 5, 2026
Merged

fix(addie): enforce common fixed-trace tool universe#7302
bokelley merged 4 commits into
mainfrom
conductor/addie-common-eval-tool-universe

Conversation

@bokelley

@bokelley bokelley commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • use an evaluator-owned, registry-derived candidate tool universe for routed/hybrid diagnostic generation
  • reject absent, legacy, or forged common-universe provenance before provider or handler boundaries
  • retain direct-arm non-admission and use synthetic receipt handlers only for component evaluation

Verification

  • npm run typecheck
  • focused fixed-trace tests (66 passing)
  • npm run validate:addie-fixed-traces
  • generated tool reference and inventory checks
  • git diff --check

Implements an evaluation prerequisite for #6842 and #6846.


Open workspace in Conductor

@bokelley
bokelley marked this pull request as ready for review September 5, 2026 22:09
@bokelley
bokelley enabled auto-merge (squash) September 5, 2026 22:09

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — clean review, no blocking or medium findings.

This PR (fix(addie): enforce common fixed-trace tool universe) touches only Addie evaluation infrastructure under server/src/addie/** and server/tests/**. No protocol wire surface (static/schemas/source/**), normative reference docs, dist/** artifacts, or migrations are affected, so the changeset is correctly absent and no schema↔docs, oneOf, or artifact-immutability gates apply.

Verified points from the review:

  • Removed FIXED_TRACE_DIRECT_TOOL_HANDLERS export was dead code with no consumers.
  • Synthetic-receipt handler-identity fidelity and binding-sha invariant are fail-closed.
  • Admission rejects absent/forged provenance before any provider dispatch or handler execution.

Decision-table walk: no critical/high (row 1 n/a); gated_paths is false (row 2 n/a); high_risk is true but all reasons are (modified) with NO medium finding, so rows 3–5 do not fire; no prior decision (row 6 n/a); no no-auto-approve team match (row 7 n/a); zero medium findings (row 8 n/a). Falls through to row 9 → approve. high_risk here is a heuristic signal on modified files with no reviewer concern, which is presumed safe.

@bokelley
bokelley merged commit ddba2ff into main Sep 5, 2026
30 checks passed
@bokelley
bokelley deleted the conductor/addie-common-eval-tool-universe branch September 5, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant