Exception break point on lookupAdConversionDetails

[areschoug]

Hi, since lookupAdConversionDetails is iOS 8+ only. Row 184 in UIDevice+ADJAdditions.m will cause an exception, but since you have a @Try{}@catch{} it won't crash the app. However if you have a "All Exceptions"-breakpoint the breakpoint will stop here, you can click continue, but it's a bit annoying. Can you add a check if respondsToSelector or check if the app version is iOS 8+?

Thank you!

[wellle]

Good point 👍

[marcotolman]

Using try/catch to handle the fact that a call to a method might fail is really bad programming. The app might still crash and we've learned that it does for some of our users.
The method is so convoluted, I can replace it with this:

#if !ADJUST_NO_IDA
    if ([[ADClient sharedClient] respondsToSelector:@selector(lookupAdConversionDetails:)]) {
        [[ADClient sharedClient] lookupAdConversionDetails:^(NSDate *appPurchaseDate, NSDate *iAdImpressionDate) {
            [activityHandler setIadDate:iAdImpressionDate withPurchaseDate:appPurchaseDate];
        }];
    }
#endif

which is way simpler and therefore easy to understand and does not cause an exception.