[pull] master from angular:master#180
Merged
pull[bot] merged 12 commits intoadmariner:masterfrom Oct 13, 2021
Merged
Conversation
This is needed because Eslint 8 requires 14.17.x or higher.
|
With this change we update the validation of the tracking id to accept tracking ids in `UA-00000-0` format. Partially addressses #21916
…ing to `uuid` `ng config cli.analyticsSharing.uuid ""` should generate new random user ID. See: https://angular.io/cli/usage-analytics-gathering#per-user-tracking
`no-unsafe-argument` was turned on by default in version 5 typescript-eslint/typescript-eslint@v4.33.0...v5.0.0#diff-b7c286fb89c9d0332d1f639cece25cf6c47223dfebd3bbfe28687335dbd494f5R15 but our code is non-compliant and causes 633 lint errors https://app.circleci.com/pipelines/github/angular/angular-cli/18477/workflows/9b33e843-3faa-4c60-a3e3-aefc4ecc9ade/jobs/271086
…e manner With this change we update the universal schematic bootstrap code to handle HMR properly. Previously, the bootstrapping code was called only on `DOMContentLoaded` which is not triggered when running in HMR. Closes #21932
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )