Replace keyword require by acdlreq to avoid conflicts with requirejs #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckautzmann
reviewed
Feb 16, 2021
| }; | ||
|
|
||
| gulp.task('lodash', shell.task(`lodash include=${configs.include.join(',')} -p -o ${configs.output}`)); | ||
| gulp.task('lodash', shell.task(`lodash exports=node include=${configs.include.join(',')} -p -o ${configs.output}`)); |
Contributor
There was a problem hiding this comment.
what does exports=node do?
Contributor
Author
There was a problem hiding this comment.
It ensures that lodash cli will build custom lodash script with export functions from nodejs api and will not use AMD or CommonJS style of exporting module. Without that parameter it did produce define keyword (to support AMD loaders) and was throwing some errors in console when requirejs was imported.
more info regarding lodash build: https://lodash.com/custom-builds
jckautzmann
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #102 by replacing
requirekeyword withacdlreqin the compiled version of ACDL in all files in dist folder using gulp implementation ofderequirepackage.