bug: duplicate initialization drops existing listeners #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rather than try to gracefully merge an existing acdl (post-augment) with one loaded later, I simply check for an existing property and, if it exists, skip initialization entirely.
Related Issue
Closes #126
Motivation and Context
See #126
How Has This Been Tested?
Using the sandbox from the issue, I proxied the unpkg import to a local built file that included the changes in this PR.
Doing so logged the warning and allowed the second event to be observed by the original listener without having to re-attach it.
See screenshot below.
Screenshots (if appropriate):
Types of changes
Checklist: