#91 data layer initialization fix #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 299 300 +1
Branches 68 69 +1
=========================================
+ Hits 299 300 +1
Continue to review full report at Codecov.
|
bpauli
reviewed
Jul 7, 2020
src/listenerManager.js
Outdated
| * @private | ||
| */ | ||
| function _callHandler(listener, item, isPastItem) { | ||
| // Fixes #91. Do not trigger event during initialization when event was pushed after adding listener and before DL initialization |
Contributor
There was a problem hiding this comment.
Just having the comment without the link to the issue id should be good enough. Users can browse the history in git to get more context if needed.
bpauli
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #91