-
Notifications
You must be signed in to change notification settings - Fork 26
Bugfix/event listener callback issue #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckautzmann
reviewed
Sep 22, 2020
Contributor
|
We should have new tests to verify the correct behaviour as described in #100:
|
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
===========================================
- Coverage 100.00% 99.32% -0.68%
===========================================
Files 12 11 -1
Lines 302 295 -7
Branches 69 66 -3
===========================================
- Hits 302 293 -9
- Misses 0 2 +2
Continue to review full report at Codecov.
|
- add test to test the behaviour: before/after script load scope = future/past
- POC: introduce an array with the items that have been added to the data layer array before the DL script had loaded - pushing each item into the data layer array (_datalayer) will process the item by using the augmented push method so the behaviour should be the same as when the DL script is loaded
jckautzmann
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100
Closes #91
This PR:
Examples:
Result: event listener will not be triggered
Result: event listener will be triggered
Result: event listener will not be triggered
Result: event listener will be triggered