Skip to content

Conversation

@cjelger
Copy link
Contributor

@cjelger cjelger commented Jan 14, 2020

  • fixed NPE in sling model
  • fixed css when the screen is very wide
  • remove "no products to display" placeholder in publish mode

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

- fixed NPE in sling model
- fixed css when the screen is very wide
- remove "no products to display" placeholder in publish mode
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #178 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #178   +/-   ##
=========================================
  Coverage     57.88%   57.88%           
  Complexity      474      474           
=========================================
  Files           148      148           
  Lines          4184     4184           
  Branches        719      719           
=========================================
  Hits           2422     2422           
  Misses         1669     1669           
  Partials         93       93
Flag Coverage Δ Complexity Δ
#jest 37.56% <ø> (ø) 0 <ø> (ø) ⬇️
#karma 94.53% <ø> (ø) 0 <ø> (ø) ⬇️
#unittests 82.54% <ø> (ø) 474 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb3a4f2...4a260dd. Read the comment docs.

@cjelger cjelger requested review from LSantha and dplaton January 14, 2020 10:55
@herzog31 herzog31 added bug Something isn't working verified and removed To Verify labels Jan 23, 2020
@herzog31 herzog31 merged commit 3e98a76 into master Jan 23, 2020
@herzog31 herzog31 deleted the CIF-1189 branch January 23, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants