Skip to content

Conversation

@mhaack
Copy link
Contributor

@mhaack mhaack commented Feb 11, 2020

Description

With Magento 2.3.4 the category image attribute returns a full URL instead of just a filename.

Related Issue

CIF-1242

Motivation and Context

Correctly display category images of Magento categories in product list banner and featured categories component.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f33323a). Click here to learn what that means.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #197   +/-   ##
=========================================
  Coverage          ?   59.38%           
  Complexity        ?      532           
=========================================
  Files             ?      146           
  Lines             ?     4331           
  Branches          ?      732           
=========================================
  Hits              ?     2572           
  Misses            ?     1662           
  Partials          ?       97
Flag Coverage Δ Complexity Δ
#jest 37.56% <ø> (?) 0 <ø> (?)
#karma 94.96% <ø> (?) 0 <ø> (?)
#unittests 83.91% <87.5%> (?) 532 <6> (?)
Impacted Files Coverage Δ Complexity Δ
...models/v1/productcarousel/ProductCarouselImpl.java 70.21% <87.5%> (ø) 14 <6> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f33323a...c4584e2. Read the comment docs.

@mhaack mhaack added the bug Something isn't working label Feb 11, 2020
@mhaack mhaack added this to the Magento 2.3.4 milestone Feb 12, 2020
@dplaton dplaton merged commit fce60bc into master Feb 20, 2020
@dplaton dplaton deleted the issues/CIF-1242 branch February 20, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working To Verify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants