Skip to content

Conversation

@cjelger
Copy link
Contributor

@cjelger cjelger commented Feb 24, 2020

… entire category page

  • ensure that a faulty product does not entirely break the display of the components displaying multiple products

How Has This Been Tested?

With LUMA, and without #209 , some category pages are broken because of bundle, grouped, and downloadable products not having a price (this triggers an NPE).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

… entire category page

- ensure that a faulty product does not entirely break the display of the components displaying multiple products
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #210 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #210      +/-   ##
============================================
+ Coverage     59.49%   59.75%   +0.26%     
+ Complexity      529      526       -3     
============================================
  Files           147      147              
  Lines          4345     4341       -4     
  Branches        736      737       +1     
============================================
+ Hits           2585     2594       +9     
+ Misses         1668     1655      -13     
  Partials         92       92
Flag Coverage Δ Complexity Δ
#jest 38.21% <100%> (+0.61%) 0 <0> (ø) ⬇️
#karma 94.97% <ø> (ø) 0 <ø> (ø) ⬇️
#unittests 84.34% <100%> (-0.08%) 526 <5> (-3)
Impacted Files Coverage Δ Complexity Δ
...ore/cif/clientlibs/common/js/CommerceGraphqlApi.js 88.33% <ø> (ø) 0 <0> (ø) ⬇️
...-components/src/components/Checkout/addressForm.js 100% <100%> (+23.52%) 0 <0> (ø) ⬇️
.../internal/models/v1/navigation/NavigationImpl.java 86.2% <100%> (ø) 23 <0> (ø) ⬇️
...s/v1/relatedproducts/RelatedProductsRetriever.java 96.22% <100%> (-0.14%) 23 <1> (-1)
...s/internal/models/v1/product/ProductRetriever.java 100% <100%> (ø) 30 <1> (-1) ⬇️
...l/models/v1/productcarousel/ProductsRetriever.java 100% <100%> (ø) 14 <1> (-1) ⬇️
...ernal/models/v1/productlist/CategoryRetriever.java 100% <100%> (ø) 16 <1> (-1) ⬇️
...rnal/models/v1/productteaser/ProductRetriever.java 84% <100%> (+0.66%) 12 <1> (+1) ⬆️
react-components/src/utils/formValidators.js 75.6% <0%> (+21.95%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb6e71...9ce24e9. Read the comment docs.

@cjelger cjelger added bug Something isn't working To Verify labels Feb 25, 2020
# Conflicts:
#	bundles/core/src/test/resources/test-queries/graphql-requests.log
@dplaton dplaton merged commit d1e4439 into master Feb 27, 2020
@dplaton dplaton deleted the CIF-1292 branch February 27, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working To Verify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants