CIF-1921 - Minimal default styling for featured category list #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* created minimal default styling for featured category list component
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
=========================================
Coverage 87.58% 87.58%
Complexity 1241 1241
=========================================
Files 232 232
Lines 5889 5889
Branches 858 858
=========================================
Hits 5158 5158
Misses 575 575
Partials 156 156
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
LSantha
requested review from
cjelger,
dplaton,
herzog31,
laurentiumagureanu and
mhaack
herzog31
approved these changes
Mar 12, 2021
| justify-content: center; | ||
| } | ||
|
|
||
| .cmp-categorylist__image { |
Member
There was a problem hiding this comment.
That kind of styling is not very nice, since we use a background with an image on top. The same can be achieved on the img tag directly using https://www.w3schools.com/css/css3_object-fit.asp.
However, that's how it was built in HTL, so let's stick to it for now.
* added copyright header for CSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created minimal default styling for featured category list component.
Related Issue
CIF-1921
How Has This Been Tested?
Manually.
Screenshots (if appropriate):
Types of changes
Checklist: