Skip to content

Conversation

@cjelger
Copy link
Contributor

@cjelger cjelger commented Apr 6, 2021

  • add support for uid parameter

How Has This Been Tested?

Extended unit tests and manually tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #536 (1bea026) into master (f0a42b2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #536   +/-   ##
=========================================
  Coverage     87.47%   87.47%           
  Complexity     1267     1267           
=========================================
  Files           232      232           
  Lines          5954     5955    +1     
  Branches        874      874           
=========================================
+ Hits           5208     5209    +1     
  Misses          582      582           
  Partials        164      164           
Flag Coverage Δ Complexity Δ
integration 64.28% <0.00%> (-0.03%) 0.00 <0.00> (ø)
jest 83.33% <ø> (ø) 0.00 <ø> (ø)
karma 94.54% <ø> (ø) 0.00 <ø> (ø)
unittests 87.61% <100.00%> (+<0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...e/components/internal/servlets/PreviewServlet.java 96.77% <100.00%> (+0.10%) 8.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0a42b2...1bea026. Read the comment docs.

@herzog31 herzog31 added enhancement New feature or request verified labels Apr 8, 2021
@herzog31 herzog31 merged commit a3682ed into master Apr 8, 2021
@herzog31 herzog31 deleted the CIF-2024 branch April 8, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants