Skip to content

Conversation

@cjelger
Copy link
Contributor

@cjelger cjelger commented Apr 7, 2021

  • adding json exporter similar to productcarousel

How Has This Been Tested?

Added unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

- adding json exporter similar to productcarousel
@cjelger cjelger added the enhancement New feature or request label Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #537 (523b246) into master (2b22643) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #537      +/-   ##
============================================
+ Coverage     87.45%   87.47%   +0.01%     
- Complexity     1263     1267       +4     
============================================
  Files           232      232              
  Lines          5948     5954       +6     
  Branches        874      874              
============================================
+ Hits           5202     5208       +6     
  Misses          582      582              
  Partials        164      164              
Flag Coverage Δ Complexity Δ
integration 64.30% <18.18%> (-0.13%) 0.00 <8.00> (ø)
jest 83.33% <ø> (ø) 0.00 <ø> (ø)
karma 94.54% <ø> (ø) 0.00 <ø> (ø)
unittests 87.61% <100.00%> (+0.02%) 0.00 <8.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...models/v1/productcarousel/ProductCarouselImpl.java 85.93% <100.00%> (ø) 26.00 <0.00> (ø)
...models/v1/relatedproducts/RelatedProductsImpl.java 88.46% <100.00%> (+1.50%) 21.00 <8.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b22643...523b246. Read the comment docs.

@cjelger cjelger marked this pull request as draft April 7, 2021 13:36
@cjelger cjelger marked this pull request as ready for review April 7, 2021 14:18
@herzog31 herzog31 merged commit f0a42b2 into master Apr 8, 2021
@herzog31 herzog31 deleted the CIF-1786 branch April 8, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants