Skip to content

Conversation

@herzog31
Copy link
Member

Description

  • Removed the selectionId parameter for all uses of cifcategoryfield where the default value is used.
  • This will allow to automatically switch to UID selections, based on the CIF cloud configuration.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added the bug Something isn't working label Apr 29, 2021
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #557 (a193b29) into master (373ac0d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #557   +/-   ##
=========================================
  Coverage     87.36%   87.36%           
  Complexity     1292     1292           
=========================================
  Files           235      235           
  Lines          6038     6038           
  Branches        890      890           
=========================================
  Hits           5275     5275           
  Misses          589      589           
  Partials        174      174           
Flag Coverage Δ Complexity Δ
integration 63.54% <ø> (ø) 883.00 <ø> (ø)
jest 83.33% <ø> (ø) 0.00 <ø> (ø)
karma 94.54% <ø> (ø) 0.00 <ø> (ø)
unittests 87.41% <ø> (ø) 1260.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 373ac0d...a193b29. Read the comment docs.

@herzog31 herzog31 marked this pull request as ready for review May 4, 2021 08:44
@buuhuu buuhuu merged commit 5e9125e into master May 18, 2021
@buuhuu buuhuu deleted the issue/CIF-2047 branch May 18, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants