-
Notifications
You must be signed in to change notification settings - Fork 79
CIF-2137: remove deprecated methods from models #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
streamline the datalayer data when price range is null
Codecov Report
@@ Coverage Diff @@
## master #603 +/- ##
============================================
+ Coverage 87.97% 88.06% +0.09%
+ Complexity 1396 1382 -14
============================================
Files 254 254
Lines 6472 6429 -43
Branches 969 964 -5
============================================
- Hits 5694 5662 -32
+ Misses 583 568 -15
- Partials 195 199 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
...a/com/adobe/cq/commerce/core/components/internal/models/v1/button/CategoryRetrieverTest.java
Show resolved
Hide resolved
...rc/main/java/com/adobe/cq/commerce/core/components/internal/models/v1/button/ButtonImpl.java
Outdated
Show resolved
Hide resolved
...es/core/src/main/java/com/adobe/cq/commerce/core/components/client/MagentoGraphqlClient.java
Show resolved
Hide resolved
| /** | ||
| * @deprecated use sling models in all cases instead | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this PR is about removing deprecated features, I wonder if there is any chance to get rid of this constructor? :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great, yes. But that would require touching a lot of unit tests. I would prefer to keep it. It is now in a private package and removing it will not cause a breaking change.
We can create a follow up story to remove it and fix the unit tests.
This change removes methods/fields marked deprecated from all Java classes.
Related Issue
CIF-2137
Motivation and Context
Major release of the CIF Core Components.
Types of changes
Checklist: