-
Notifications
You must be signed in to change notification settings - Fork 79
CIF-2222: Add config for storefront context render #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| public String getJson() { | ||
| try { | ||
| return new ObjectMapper().writeValueAsString(this); | ||
| if (isStorefrontContextEnabled()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a test that covers the isStorefrontContextEnabled() = false case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added now
|
LGTM As @buuhuu mentioned, please add a test case to test the behavior if the setting is disabled. |
added now |
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
============================================
- Coverage 88.03% 87.99% -0.04%
- Complexity 1526 1527 +1
============================================
Files 278 278
Lines 6777 6789 +12
Branches 1009 1011 +2
============================================
+ Hits 5966 5974 +8
Misses 620 620
- Partials 191 195 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Description
Render storefront context data based on config
Related Issue
CIF-2222
Motivation and Context
product recs
How Has This Been Tested?
unit tests
Screenshots (if appropriate):
Types of changes
Checklist: