-
Notifications
You must be signed in to change notification settings - Fork 79
CIF-1502 - XF based page header with authoring support #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* added version 2 for the following components to make them usable in the page editor: accountedtails, addressbook, minicart, resetpassword, searchbar, miniaccount
* fixed link in README.md
* typo in README.md
Codecov Report
@@ Coverage Diff @@
## master #650 +/- ##
=========================================
Coverage 88.41% 88.41%
Complexity 1593 1593
=========================================
Files 280 280
Lines 6975 6975
Branches 1045 1045
=========================================
Hits 6167 6167
Misses 610 610
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@LSantha What do you think about introducing a generic "Frontend Placeholder" component instead of having 5 individual placeholder components? The component could have a dialog with a select field to select between predefined placeholders (accountedtails, addressbook, minicart, resetpassword, miniaccount) and a free textfield to use a custom CSS class in case customers want to add additional frontend components. |
|
I think from an authoring standpoint and also for future evolution the current approach is better. |
* deprecated the header component
* deprecated the header component
Added version 2 for the following components to make them usable in the page editor: accountedtails, addressbook, minicart, resetpassword, searchbar, miniaccount.
Related Issue
CIF-1502
How Has This Been Tested?
Manually.
Types of changes
Checklist: