CIF-2305 - fix raw product access for mapped product product list items #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #661 +/- ##
============================================
+ Coverage 88.42% 88.44% +0.02%
- Complexity 1594 1598 +4
============================================
Files 280 280
Lines 6978 6986 +8
Branches 1046 1047 +1
============================================
+ Hits 6170 6179 +9
Misses 610 610
+ Partials 198 197 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dplaton
approved these changes
Aug 19, 2021
| : CommerceIdentifierImpl.fromProductSku(sku); | ||
| } | ||
|
|
||
| public ProductListItemImpl(ProductInterface product, Page productPage, String activeVariantSku, SlingHttpServletRequest request, |
Contributor
There was a problem hiding this comment.
This is the third constructor for this class. I think we should consider using another pattern for constructing these objects, maybe a "Builder"?
herzog31
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ProductListItemdid not give any access to the full product retrieved from backend, hence extended queries with custom attributes did not work since the retrieved custom attributes could not be accessed.With this the a project developer gets access to the entire product retrieved from the backend.
Related Issue
CIF-2305
How Has This Been Tested?
Added unit test.
Types of changes
Checklist: