Skip to content

Conversation

@buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Aug 26, 2021

Description

This PR removes the sku's from the productlist's placeholder data. This makes sure that they are not rendered to the markup as data attributes and so are not picked up by the associated content tab.

Related Issue

CIF-2334

How Has This Been Tested?

Unit Tests, Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@buuhuu buuhuu added the bug Something isn't working label Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #669 (993ef0d) into master (c229a2f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #669   +/-   ##
=========================================
  Coverage     88.58%   88.58%           
  Complexity     1598     1598           
=========================================
  Files           282      282           
  Lines          7129     7129           
  Branches       1046     1046           
=========================================
  Hits           6315     6315           
  Misses          618      618           
  Partials        196      196           
Flag Coverage Δ
integration 59.74% <ø> (ø)
jest 85.61% <ø> (ø)
karma 90.01% <ø> (ø)
unittests 89.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c229a2f...993ef0d. Read the comment docs.

@herzog31 herzog31 merged commit 460a61f into master Sep 3, 2021
@herzog31 herzog31 deleted the issue/CIF-2334 branch September 3, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants