Skip to content

Conversation

@LSantha
Copy link
Collaborator

@LSantha LSantha commented Sep 6, 2021

Make sure the searchbox listener is registered also in situations where the searchbar toggle is not used.

Related Issue

CIF-2328

How Has This Been Tested?

Manually, Unit test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

 * make sure the searchbox listener is registered also in situations where the searchbar toggle is not used
@LSantha LSantha added the bug Something isn't working label Sep 6, 2021
@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #678 (fe54be4) into master (a93d644) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #678   +/-   ##
=========================================
  Coverage     88.71%   88.71%           
  Complexity     1604     1604           
=========================================
  Files           282      282           
  Lines          7140     7140           
  Branches       1053     1053           
=========================================
  Hits           6334     6334           
  Misses          609      609           
  Partials        197      197           
Flag Coverage Δ
integration 59.61% <ø> (ø)
jest 85.97% <ø> (ø)
karma 90.03% <100.00%> (ø)
unittests 89.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../searchbar/v2/searchbar/clientlibs/js/searchbar.js 96.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93d644...fe54be4. Read the comment docs.

@mhaack mhaack merged commit afc11a4 into master Sep 16, 2021
@mhaack mhaack deleted the CIF-2328 branch September 16, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants