CIF-2215 - Breadcrumb error when no dynamic category page is present

[LSantha]

Fixed NPEs when dynamic categoryPage or productPage is null.

Related Issue

CIF-2215

How Has This Been Tested?

Manually, unit tests.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes and the overall coverage did not decrease.
• All unit tests pass on CircleCi.
• I ran all tests locally and they pass.

[codecov]

Codecov Report

Merging #697 (c85ea85) into master (89d906e) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master     #697      +/-   ##
============================================
- Coverage     88.58%   88.57%   -0.01%     
- Complexity     1600     1604       +4     
============================================
  Files           282      282              
  Lines          7131     7135       +4     
  Branches       1048     1051       +3     
============================================
+ Hits           6317     6320       +3     
  Misses          618      618              
- Partials        196      197       +1     

Flag	Coverage Δ
integration	59.65% <50.00%> (-0.06%)	⬇️
jest	85.61% <ø> (ø)
karma	90.01% <ø> (ø)
unittests	89.03% <80.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../internal/models/v1/breadcrumb/BreadcrumbImpl.java	90.21% <80.00%> (-0.70%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d906e...c85ea85. Read the comment docs.

[buuhuu]

trivial: while we are on it this check should probably be done using Text.isDescendant https://www.adobe.io/experience-manager/reference-materials/6-5/javadoc/com/day/text/Text.html#isDescendantOrEqual-java.lang.String-java.lang.String-

[mhaack]

Also https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html#contains-java.lang.CharSequence-java.lang.CharSequence (which is already used in this class) can be used that includes the null check.

[mhaack]

Also https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html#contains-java.lang.CharSequence-java.lang.CharSequence (which is already used in this class) can be used that includes the null check.