FORMS-11692 : Upgrade af2-web-runtime version and add Rule editor UI end to end test cases in Forms Core Components #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 4, 2024 14:28
github-actions
bot
force-pushed
the
FORMS-11692
branch
from
952585a to
f676079
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1111 +/- ##
=========================================
Coverage 80.82% 80.82%
Complexity 774 774
=========================================
Files 92 92
Lines 2117 2117
Branches 285 285
=========================================
Hits 1711 1711
Misses 252 252
Partials 154 154 ☔ View full report in Codecov by Sentry. |
rismehta
reviewed
Mar 6, 2024
| closeRuleEditor : ".exp-Close-Button" | ||
| closeRuleEditor : ".exp-Close-Button", | ||
| sideToggleButton : "#exp-toggle-sidepanel-button", | ||
| formObjectsTab : ".exp-sidepanel coral-tabview coral-tab coral-tab-label:first", |
Collaborator
There was a problem hiding this comment.
Is it possible to have a specific selector without having coral dependency ?
Contributor
Author
There was a problem hiding this comment.
There is no specific selector available for the tabs currently. So we will have to depend upon the coral tag.
rismehta
reviewed
Mar 6, 2024
| formsSelectors = require('../../libs/commons/guideSelectors'), | ||
| afConstants = require('../../libs/commons/formsConstants'); | ||
|
|
||
| describe('Rule editor sanity for core-components',function(){ |
Collaborator
There was a problem hiding this comment.
Can we also add these test cases in SITE page, you can refer other test cases, we follow this pattern everywhere
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Contributor
Author
|
moved to new PR: #1117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: