FORMS-11692: upgraded af2-web-runtime version and added rule editor t… #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
10 tasks
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1117 +/- ##
=========================================
Coverage 80.74% 80.74%
Complexity 771 771
=========================================
Files 91 91
Lines 2108 2108
Branches 285 285
=========================================
Hits 1702 1702
Misses 252 252
Partials 154 154 ☔ View full report in Codecov by Sentry. |
rismehta
reviewed
Mar 7, 2024
| @@ -0,0 +1,79 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:fd="http://www.adobe.com/aemfd/fd/1.0" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" | |||
Collaborator
There was a problem hiding this comment.
Examples is deployed today in aemcomponents.dev which should only consists of component collaterals, ideally this collateral should be under content folder inside it (ie) https://github.com/adobe/aem-core-forms-components/tree/master/it/content/src/main/content/jcr_root/content/forms/sites
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
reviewed
Mar 21, 2024
| jcr:lastModifiedBy="admin" | ||
| jcr:primaryType="nt:unstructured" | ||
| sling:resourceType="forms-components-examples/components/form/container" | ||
| clientLibRef="corecomponent.it.ruleeditor,corecomponent.it.customfunction" |
Collaborator
There was a problem hiding this comment.
What's the rationale behind having two client libraries? If they serve different purposes, shouldn't we name them accordingly to reflect their use cases? Currently, corecomponent.it.ruleeditor and corecomponent.it.ruleeditor aren't very intuitive in terms of understanding their intended functions.
Contributor
Author
There was a problem hiding this comment.
It is to test the functionality that form can handle more than one clientlib category and we get a merged list of custom functions on form.
Collaborator
There was a problem hiding this comment.
In that case, can we rename the client library category name ? They are not readable.
Contributor
Author
There was a problem hiding this comment.
Done.
I am keeping category name as corecomponent.it.customfunction and corecomponent.it.customfunction2
also added a test case to make it clear.
added 14 commits
March 21, 2024 07:46
github-actions
bot
force-pushed
the
FORMS-11692-new
branch
from
e960234 to
480072e
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
ravise5
pushed a commit
that referenced
this pull request
Mar 26, 2024
#1117) * FORMS-11692: upgraded af2-web-runtime version and added rule editor tests * FORMS-11692: upgraded af2-web-runtime version and added rule editor tests * FORMS-11692: upgraded af2-web-runtime version and added rule editor tests * FORMS-11692: upgraded af2-web-runtime version and added rule editor tests * FORMS-11692: upgraded af2-web-runtime version and added rule editor tests * FORMS-11692: updated getParentFormElementId method to check for form fieldType * FORMS-11692: updated af2-runtime and remove authoring tests for rule editor. * FORMS-11692: upgraded af2-web-runtime version and added rule editor tests * FORMS-11692: upgraded af2-web-runtime version and added rule editor tests * FORMS-11692: upgraded af2-web-runtime version and added rule editor tests * FORMS-11692: updated getParentFormElementId method to check for form fieldType * FORMS-11692: updated tests * FORMS-11692: updated tests * FORMS-11692: added test case for merged custom function list from two clientlibs --------- Co-authored-by: Arun Kumar Attri <aattri@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ests
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: