Add support for displayValueExpression #1126

ravise5 · 2024-03-15T06:37:00Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

adobe-bot · 2024-03-15T06:55:42Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-15T06:55:42Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	87	100	100	73

adobe-bot · 2024-03-15T06:55:52Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-15T06:57:38Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-15T07:35:55Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-15T07:35:55Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	88	100	100	73

adobe-bot · 2024-03-15T07:36:06Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-15T07:37:48Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-15T07:38:18Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-18T07:11:06Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	90	100	100	73

adobe-bot · 2024-03-18T07:11:06Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-18T07:11:16Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-18T07:12:17Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-18T07:15:34Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

...re/src/test/resources/schema/0.12.5/adaptive-form-aem-responsive-grid-properties.schema.json

.../src/main/java/com/adobe/cq/forms/core/components/internal/models/v1/form/TextInputImpl.java

bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/DatePicker.java

rismehta

check comments

rismehta · 2024-03-18T09:08:08Z

@ravise5 Additionally, you also need to persist the specVersion in guideContainer. I have tagged you in a slack thread, please incorporate the same with this change

adobe-bot · 2024-03-18T10:37:44Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-18T10:37:44Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	100	100	73

adobe-bot · 2024-03-18T10:37:55Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-18T14:55:28Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	100	100	73

adobe-bot · 2024-03-18T14:55:28Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-18T14:55:38Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-18T14:59:54Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-18T14:59:54Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	100	100	73

adobe-bot · 2024-03-18T15:00:06Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T07:50:44Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-21T07:50:44Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	89	100	100	73

adobe-bot · 2024-03-21T07:50:55Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T07:53:05Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T07:54:54Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T10:05:47Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	100	100	73

adobe-bot · 2024-03-21T10:05:47Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-21T10:05:58Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T10:08:33Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T10:09:49Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T10:24:43Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	100	100	73

adobe-bot · 2024-03-21T10:24:43Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-21T10:24:54Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T10:25:17Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T10:25:26Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T10:59:36Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	100	100	73

adobe-bot · 2024-03-21T10:59:36Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-21T10:59:47Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T11:00:28Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-21T11:01:12Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

resolved all the issues

* Add support for displayValueExpression * Exposed displayValueExpression for telephone,text,email and date input * Added e2e tests * Add theme to datepicker tests as the date picker widget doesn't work without a theme * RTC(done) specVersion updated in formContainer * RTC Persisting spec Version in guideContainer node * Saving specVersion when formContainer dialog is saved

rismehta reviewed Mar 18, 2024

View reviewed changes

...re/src/test/resources/schema/0.12.5/adaptive-form-aem-responsive-grid-properties.schema.json Outdated Show resolved Hide resolved

rismehta reviewed Mar 18, 2024

View reviewed changes

.../src/main/java/com/adobe/cq/forms/core/components/internal/models/v1/form/TextInputImpl.java Outdated Show resolved Hide resolved

rismehta reviewed Mar 18, 2024

View reviewed changes

bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/DatePicker.java Outdated Show resolved Hide resolved

rismehta requested changes Mar 18, 2024

View reviewed changes

github-actions bot force-pushed the numberinput-dve branch from 6991112 to 480269b Compare March 18, 2024 10:15

github-actions bot force-pushed the numberinput-dve branch from a414444 to 76ad91f Compare March 18, 2024 14:31

github-actions bot force-pushed the numberinput-dve branch from d20b139 to 4ff5af4 Compare March 21, 2024 07:30

ravise5 added 3 commits March 21, 2024 15:15

Merge branch 'dev' into numberinput-dve

7b704d5

RTC fix tests

6ecd66f

RTC fix formatting

4cd0179

RTC fix tests

bba5c50

vdua approved these changes Mar 22, 2024

View reviewed changes

vdua merged commit 7f7b068 into dev Mar 22, 2024

Add support for displayValueExpression #1126

Add support for displayValueExpression #1126

Uh oh!

Conversation

ravise5 commented Mar 15, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

adobe-bot commented Mar 15, 2024

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Mar 15, 2024

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Mar 15, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 15, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 15, 2024

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Mar 15, 2024

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Mar 15, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 15, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 15, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 18, 2024

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Mar 18, 2024

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Mar 18, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 18, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 18, 2024

Accessibility Violations Found

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rismehta left a comment

Choose a reason for hiding this comment

Uh oh!

rismehta commented Mar 18, 2024

Uh oh!

adobe-bot commented Mar 18, 2024

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Mar 18, 2024

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Mar 18, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 18, 2024

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Mar 18, 2024

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Mar 18, 2024

Accessibility Violations Found