Skip to content

Conversation

@rismehta
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

rajatofficial and others added 3 commits March 18, 2024 15:57
* FORMS-13392 role main check added

* FORMS-13392 role main check added I

---------

Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>
@codecov
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (3860224) to head (a60c0a1).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1130      +/-   ##
============================================
- Coverage     80.82%   80.74%   -0.09%     
+ Complexity      774      771       -3     
============================================
  Files            92       91       -1     
  Lines          2117     2108       -9     
  Branches        285      285              
============================================
- Hits           1711     1702       -9     
  Misses          252      252              
  Partials        154      154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@rismehta rismehta merged commit ea5bc19 into master Mar 18, 2024
@rismehta rismehta deleted the devMaster1803 branch March 18, 2024 16:33
rismehta added a commit that referenced this pull request Mar 27, 2024
This reverts commit ea5bc19, reversing
changes made to 3860224.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants