-
Notifications
You must be signed in to change notification settings - Fork 63
Fixes datepicker layout issues #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1134 +/- ##
=========================================
Coverage 80.74% 80.74%
Complexity 771 771
=========================================
Files 91 91
Lines 2108 2108
Branches 285 285
=========================================
Hits 1702 1702
Misses 252 252
Partials 154 154 ☔ View full report in Codecov by Sentry. |
rismehta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might impact existing customer forms, did you check the backward compatibility issues with this change ?
I have checked for OOB AEM supported locales, these are working fine. It might break for those locales where month names are larger. For those locales we are still giving custom CSS. Confirmed with @sakshi-arora1 cc : @sakshi-arora1 @rismehta |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: