Skip to content

Conversation

@vaibhav2601
Copy link
Contributor

Updating the af-custom-functions to 1.0.9

Description

FORMS-14041: Screen Reader is not notifying upon submission of a Form

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@vaibhav2601 vaibhav2601 requested a review from rismehta July 8, 2024 09:00
@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 100 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@codecov
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (371c2a0) to head (340bf20).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1304   +/-   ##
=========================================
  Coverage     81.52%   81.52%           
  Complexity      847      847           
=========================================
  Files            96       96           
  Lines          2252     2252           
  Branches        307      307           
=========================================
  Hits           1836     1836           
  Misses          256      256           
  Partials        160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rismehta rismehta merged commit 1be994b into master Jul 8, 2024
rismehta added a commit that referenced this pull request Jul 8, 2024
rismehta added a commit that referenced this pull request Jul 8, 2024
rismehta pushed a commit that referenced this pull request Jul 11, 2024
Co-authored-by: Vaibhav Varshney <vavarshn@adobe.com>
rismehta added a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants