Fixing enabled and visible attributes of Button CC #1308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
github-actions
bot
force-pushed
the
ButtonCCFix
branch
from
e49ad42 to
de5dfb6
Compare
github-actions
bot
force-pushed
the
ButtonCCFix
branch
from
1130fb6 to
370d255
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1308 +/- ##
=========================================
Coverage 81.73% 81.73%
Complexity 853 853
=========================================
Files 97 97
Lines 2267 2267
Branches 305 305
=========================================
Hits 1853 1853
Misses 255 255
Partials 159 159 ☔ View full report in Codecov by Sentry. |
rismehta
reviewed
Jul 23, 2024
| expect(formContainer._model.items.length, "model and view elements match").to.equal(Object.keys(formContainer._fields).length); | ||
| Object.entries(formContainer._fields).forEach(([id, field]) => { | ||
| if(field.options.visible === "true") { | ||
| if(field.options.visible === "true" && field.getModel()._jsonModel.fieldType==='text-input') { |
Collaborator
There was a problem hiding this comment.
Why is there a change in an existing test case ? This can impact backward compatibility
Member
Author
There was a problem hiding this comment.
Attributes 'data-cmp-enabled' and 'data-cmp-visible' are causing button to be present always in the form which is why the checkHTML will fail if we do not explicitly check for 'text-input'. I have confirmed all components in both textinput and customtextinput test files have all components with fieldType 'text-input' apart from a submit button.
rismehta
approved these changes
Jul 26, 2024
rismehta
approved these changes
Jul 26, 2024
dmaurya929
pushed a commit
that referenced
this pull request
Aug 13, 2024
* Fixing enabled and visible attributes of Button CC * Updating test cases to check fieldType to support button attribute changes --------- Co-authored-by: Muskan Gupta <muskgupta@Muskans-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the enabled and visible attributes to reflect correctly in forms for button core component.
JIRA : https://jira.corp.adobe.com/browse/FORMS-15167
Related Issue
Motivation and Context
Without this change, the button component in forms was not correctly populating true and false values to 'data-cmp-enabled' and 'data-cmp-visible' attributes.
How Has This Been Tested?
Tested the changes using cypress.
Screenshots (if appropriate):
Types of changes
Checklist: