Fixing exclusive maximum and minimum issue #1328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1328 +/- ##
============================================
- Coverage 81.73% 81.71% -0.03%
- Complexity 853 855 +2
============================================
Files 97 97
Lines 2267 2269 +2
Branches 305 306 +1
============================================
+ Hits 1853 1854 +1
Misses 255 255
- Partials 159 160 +1 ☔ View full report in Codecov by Sentry. |
| public static final String PN_EXCLUSIVE_MAXIMUM = "exclusiveMaximum"; | ||
| public static final String PN_EXCLUDE_MINIMUM = "excludeMinimum"; | ||
| public static final String PN_EXCLUDE_MAXIMUM = "excludeMaximum"; | ||
| public static final String PN_EXCLUDE_MINIMUM_CHECK = "excludeMinimumCheck"; |
Contributor
There was a problem hiding this comment.
What is difference between PN_EXCLUDE_MINIMUM and PN_EXCLUDE_MINIMUM_CHECK ?
Collaborator
Author
There was a problem hiding this comment.
These are old values, which was not reviewed correctly, now we need to maintain it to support old content structures
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
5 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
added a commit
that referenced
this pull request
Jul 25, 2024
* Fixing exclusive maximum and minimum issue with number input * Fixing exclusive maximum and minimum issue with date picker * Adding test cases as per the customer use-case * updating package lock * Fixing test case * Fixing test case
rismehta
added a commit
that referenced
this pull request
Jul 25, 2024
* Fixing exclusive maximum and minimum issue with number input * Fixing exclusive maximum and minimum issue with date picker * Adding test cases as per the customer use-case * updating package lock * Fixing test case * Fixing test case
dmaurya929
pushed a commit
that referenced
this pull request
Aug 13, 2024
* Fixing exclusive maximum and minimum issue with number input * Fixing exclusive maximum and minimum issue with date picker * Adding test cases as per the customer use-case * updating package lock * Fixing test case * Fixing test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: