Skip to content

Forms-14212 Implemented time based auto save #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2024
Merged

Forms-14212 Implemented time based auto save #1337

merged 1 commit into from
Aug 8, 2024

Conversation

@navneet-ag
Copy link
Contributor

@navneet-ag navneet-ag commented Jul 25, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@adobe-bot
Copy link

adobe-bot commented Jul 25, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

@adobe-bot
Copy link

adobe-bot commented Jul 25, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

adobe-bot commented Jul 25, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Jul 25, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Jul 25, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

nit23uec
nit23uec reviewed Jul 26, 2024
View reviewed changes
nit23uec
nit23uec reviewed Jul 26, 2024
View reviewed changes
nit23uec
nit23uec reviewed Jul 26, 2024
View reviewed changes
nit23uec
nit23uec reviewed Jul 26, 2024
View reviewed changes
nit23uec
nit23uec requested changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@nit23uec nit23uec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline comments

@nit23uec
Copy link
Collaborator

nit23uec commented Jul 26, 2024

Pls avoid referencing internal jira Ids in public space

nit23uec
nit23uec reviewed Jul 26, 2024
View reviewed changes
@rismehta
Copy link
Collaborator

rismehta commented Jul 26, 2024

Pls avoid referencing internal jira Ids in public space

FYI, #1326 (comment). There is no harm in referencing internal JIRA ID

rismehta
rismehta requested changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments. This would require another review

@adobe-bot
Copy link

adobe-bot commented Jul 30, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

@adobe-bot
Copy link

adobe-bot commented Jul 30, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

adobe-bot commented Jul 30, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Jul 30, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Jul 30, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 7, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

1 similar comment
@adobe-bot
Copy link

adobe-bot commented Aug 7, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 7, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

@adobe-bot
Copy link

adobe-bot commented Aug 7, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

adobe-bot commented Aug 7, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Aug 7, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 7, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 96 96 75

@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@girotraapankaj girotraapankaj requested a review from rismehta August 8, 2024 06:56
@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 89 96 96 75

@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 96 96 75

@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@girotraapankaj girotraapankaj merged commit 8256a6d into dev Aug 8, 2024
dmaurya929 pushed a commit that referenced this pull request Aug 13, 2024
@navneet-ag @girotraapankaj @dmaurya929
Forms-14212 Implemented time based auto save (#1337)
3dde5dd 
Co-authored-by: Pankaj <pank@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nit23uec nit23uec nit23uec approved these changes

@rismehta rismehta rismehta approved these changes

@girotraapankaj girotraapankaj Awaiting requested review from girotraapankaj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@navneet-ag @adobe-bot @nit23uec @rismehta @girotraapankaj