Fixing Min/Max dialog fields for number input, when the type is decimal #1348

vdua · 2024-08-08T22:23:01Z

randomly chosen step as 0.01 for decimal, but it can be author defined

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

- randomly chosen step as 0.01 for decimal, but it can be author defined

adobe-bot · 2024-08-08T22:40:19Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-08-08T22:43:49Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-08-08T22:45:54Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	90	96	96	75

adobe-bot · 2024-08-08T22:45:54Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-08-08T22:45:56Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-08T22:46:00Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-08-08T22:46:06Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-08T22:46:42Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-08T22:48:50Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	96	96	75

adobe-bot · 2024-08-08T22:48:50Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-08-08T22:49:01Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-08T22:49:28Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-08T22:50:13Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-08T22:51:06Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-08-08T22:51:06Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	89	96	96	75

adobe-bot · 2024-08-08T22:51:16Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-08T22:53:18Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-08T22:53:29Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-11T10:26:58Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-08-11T10:31:34Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-08-11T10:31:34Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	96	96	75

adobe-bot · 2024-08-11T10:31:45Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-11T10:32:41Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

vdua · 2024-08-12T06:07:59Z

bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/package-info.java

 */

-@Version("5.5.4") // aligning this with release/650 since af2-rest-api is compiled with 5.2.0 in release/650
+@Version("5.6.4") // aligning this with release/650 since af2-rest-api is compiled with 5.2.0 in release/650


the comment doesn't make sense here.

vdua · 2024-08-12T06:10:59Z

...t/apps/core/fd/components/form/numberinput/v1/numberinput/clientlibs/editor/js/editDialog.js

+                if (maxInput.value.includes('.')) {
+                    maxInput.value = Math.floor(maxInput.value);
+                    maxInput.setAttribute('value', maxInput.value);
+                }


can we add a test case for this use case where changing from number to integer, changes the min/max constraint as well

adobe-bot · 2024-08-12T09:21:33Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-08-12T09:26:46Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-12T09:26:56Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-08-12T09:26:56Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	90	96	96	75

adobe-bot · 2024-08-12T09:27:07Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-12T09:28:14Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-12T09:31:01Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-08-12T09:35:27Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-08-12T09:35:27Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	90	96	96	75

adobe-bot · 2024-08-12T09:35:38Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-12T09:37:06Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-12T09:37:50Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

codecov · 2024-08-12T09:41:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (8256a6d) to head (7a9e477).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #1348      +/-   ##
============================================
+ Coverage     81.76%   81.94%   +0.17%     
- Complexity      881      899      +18     
============================================
  Files           101      103       +2     
  Lines          2314     2337      +23     
  Branches        314      317       +3     
============================================
+ Hits           1892     1915      +23     
  Misses          259      259              
  Partials        163      163

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adobe-bot · 2024-08-12T12:59:12Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-08-12T13:05:27Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	90	96	96	75

adobe-bot · 2024-08-12T13:05:27Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-08-12T13:05:38Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-12T13:06:39Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-08-12T13:08:19Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

rismehta · 2024-08-12T13:10:07Z

Merging this, since @vdua has already reviewed the changes.

…al (#1348) * Fixing Min/Max dialog fields for number input, when the type is decimal - randomly chosen step as 0.01 for decimal, but it can be author defined * fixing indentation * the correct value for decimal type is number * Adding support for decimal in minimum/maximum * Addressing review comments and adding more test cases * Removing skipped test * Adding more test --------- Co-authored-by: Rishi Mehta <rismehta@adobe.com>

Fixing Min/Max dialog fields for number input, when the type is decimal

f443a6c

- randomly chosen step as 0.01 for decimal, but it can be author defined

vdua requested a review from rismehta August 8, 2024 22:23

vdua marked this pull request as draft August 8, 2024 22:23

vdua added 2 commits August 9, 2024 03:56

fixing indentation

c98f4ab

the correct value for decimal type is number

996716b

Adding support for decimal in minimum/maximum

b94e93c

rismehta marked this pull request as ready for review August 11, 2024 10:05

vdua commented Aug 12, 2024

View reviewed changes

rismehta added 2 commits August 12, 2024 14:29

Addressing review comments and adding more test cases

c893238

Removing skipped test

116473f

Adding more test

7a9e477

rismehta merged commit 30da958 into dev Aug 12, 2024

rismehta deleted the number-input-min-max-decimal branch August 12, 2024 13:10

Fixing Min/Max dialog fields for number input, when the type is decimal #1348

Fixing Min/Max dialog fields for number input, when the type is decimal #1348

Uh oh!

Conversation

vdua commented Aug 8, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 8, 2024

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Aug 8, 2024

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 8, 2024

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Aug 8, 2024

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 8, 2024

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Aug 8, 2024

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 8, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 11, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 11, 2024

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Aug 11, 2024

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Aug 11, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 11, 2024

codecov bot commented Aug 12, 2024 •

edited

Loading