Skip to content

FORMS-15150 Runtime client libraries are loaded in authoring for tabs… #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 26, 2024
Merged

FORMS-15150 Runtime client libraries are loaded in authoring for tabs… #1355

merged 11 commits into from
Aug 26, 2024

Conversation

@dmaurya929
Copy link
Contributor

@dmaurya929 dmaurya929 commented Aug 13, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@dmaurya929
Copy link
Contributor Author

dmaurya929 commented Aug 13, 2024

This is new PR of #1293
All review comments are incorporated !!

@dmaurya929 dmaurya929 requested a review from rismehta August 13, 2024 18:58
@adobe-bot
Copy link

adobe-bot commented Aug 13, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 14, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 14, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 87 96 96 75

@adobe-bot
Copy link

adobe-bot commented Aug 14, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

adobe-bot commented Aug 14, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Aug 14, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 14, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 20, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 20, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

adobe-bot commented Aug 20, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 90 96 96 75

@adobe-bot
Copy link

adobe-bot commented Aug 20, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Aug 20, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 20, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 23, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 23, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

sakshi-arora1
sakshi-arora1 reviewed Aug 26, 2024
View reviewed changes
....apps/src/main/content/jcr_root/apps/core/fd/components/af-commons/v1/clientlibs/tabs/js.txt
@@ -0,0 +1,18 @@
###############################################################################
# Copyright 2023 Adobe
Copy link
Contributor

@sakshi-arora1 sakshi-arora1 Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024

@adobe-bot
Copy link

adobe-bot commented Aug 26, 2024

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 26, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

adobe-bot commented Aug 26, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 89 96 96 75

@adobe-bot
Copy link

adobe-bot commented Aug 26, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Aug 26, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Aug 26, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (30da958) to head (87846b5).
Report is 3 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##                dev    #1355   +/-   ##
=========================================
  Coverage     81.94%   81.94%           
  Complexity      899      899           
=========================================
  Files           103      103           
  Lines          2337     2337           
  Branches        317      317           
=========================================
  Hits           1915     1915           
  Misses          259      259           
  Partials        163      163

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sakshi-arora1 sakshi-arora1 merged commit da72640 into dev Aug 26, 2024
rismehta added a commit that referenced this pull request Sep 9, 2024
@rismehta
Revert "FORMS-15150 Runtime client libraries are loaded in authoring …
fc7796f 
…for tabs… (#1355)"

This reverts commit da72640.
@rismehta rismehta mentioned this pull request Sep 9, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sakshi-arora1 sakshi-arora1 sakshi-arora1 approved these changes

@rismehta rismehta Awaiting requested review from rismehta

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmaurya929 @adobe-bot @sakshi-arora1