[FORMS-16370] [FORMS-16201] Re-saving of draft creates new draft instead of updating existing draft #1503

girotraapankaj · 2025-01-13T07:08:49Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

codecov · 2025-01-13T09:17:28Z

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.42%. Comparing base (0d552d7) to head (d871a00).
Report is 1 commits behind head on dev.

Files with missing lines	Patch %	Lines
...nts/internal/models/v2/form/FormContainerImpl.java	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #1503      +/-   ##
============================================
+ Coverage     82.33%   82.42%   +0.08%     
- Complexity      963      969       +6     
============================================
  Files           107      107              
  Lines          2485     2492       +7     
  Branches        339      342       +3     
============================================
+ Hits           2046     2054       +8     
+ Misses          264      262       -2     
- Partials        175      176       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adobe-bot · 2025-01-13T09:26:49Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-13T09:31:52Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-13T09:31:52Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	96	75

adobe-bot · 2025-01-13T09:31:52Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-13T09:32:02Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-13T09:32:21Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-13T11:19:07Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-13T11:23:00Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-01-13T11:23:00Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-13T11:23:11Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-01-13T11:23:17Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-13T11:24:13Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-14T09:55:35Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-14T09:59:09Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-01-14T09:59:09Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-14T09:59:20Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-14T10:00:27Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-14T10:00:54Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T07:30:39Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-16T07:30:39Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-01-16T07:30:49Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T07:32:08Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T07:32:10Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T07:54:41Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-16T07:58:37Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	96	96	75

adobe-bot · 2025-01-16T07:58:37Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-16T07:58:48Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T07:59:30Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T08:00:07Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

…ting draft

adobe-bot · 2025-01-16T09:31:12Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-16T09:35:21Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-16T09:35:21Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-01-16T09:35:32Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T09:37:06Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-01-16T09:37:30Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T10:51:38Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2025-01-16T10:56:51Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-01-16T10:56:51Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-01-16T10:56:52Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T10:57:02Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-01-16T10:58:31Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

girotraapankaj marked this pull request as draft January 13, 2025 07:08

github-actions bot force-pushed the FORMs-16370 branch from 9ff7853 to dc3bf7d Compare January 13, 2025 07:09

girotraapankaj force-pushed the FORMs-16370 branch from dc3bf7d to 39ada0e Compare January 13, 2025 08:23

github-actions bot force-pushed the FORMs-16370 branch from 39ada0e to 483f4fe Compare January 13, 2025 08:23

girotraapankaj force-pushed the FORMs-16370 branch from 483f4fe to 88617aa Compare January 13, 2025 09:07

github-actions bot force-pushed the FORMs-16370 branch from 88617aa to 7020b9e Compare January 13, 2025 09:07

girotraapankaj marked this pull request as ready for review January 13, 2025 13:41

girotraapankaj requested a review from rismehta January 13, 2025 13:42

girotraapankaj force-pushed the FORMs-16370 branch from 7020b9e to c6926bf Compare January 14, 2025 09:34

github-actions bot force-pushed the FORMs-16370 branch from c6926bf to 4532831 Compare January 14, 2025 09:34

girotraapankaj changed the title ~~FORMS-16370 Re-saving of draft creates new draft instead of updating existing draft~~ [FORMS-16370] [FORMS-16201] Re-saving of draft creates new draft instead of updating existing draft Jan 14, 2025

girotraapankaj force-pushed the FORMs-16370 branch from 4ced972 to 0eb9627 Compare January 16, 2025 09:12

girotraapankaj added 2 commits January 16, 2025 09:13

[Draft] Re-saving of draft creates new draft instead of updating exis…

7c39a35

…ting draft

FORMS-16201 Register auto save in publish(disabled) mode only

d871a00

github-actions bot force-pushed the FORMs-16370 branch from 0eb9627 to d871a00 Compare January 16, 2025 09:13

rismehta approved these changes Jan 17, 2025

View reviewed changes

rismehta merged commit b8a0c36 into dev Jan 17, 2025
10 checks passed

rismehta deleted the FORMs-16370 branch January 17, 2025 11:06

[FORMS-16370] [FORMS-16201] Re-saving of draft creates new draft instead of updating existing draft #1503

[FORMS-16370] [FORMS-16201] Re-saving of draft creates new draft instead of updating existing draft #1503

Uh oh!

Conversation

girotraapankaj commented Jan 13, 2025

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

codecov bot commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Jan 13, 2025

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Jan 13, 2025

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Jan 13, 2025

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Jan 13, 2025

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Jan 13, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Jan 14, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Jan 14, 2025

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Jan 14, 2025

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Jan 14, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Jan 14, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Jan 14, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Jan 16, 2025

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Jan 16, 2025

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Jan 16, 2025

Accessibility Violations Found

Uh oh!

codecov bot commented Jan 13, 2025 •

edited

Loading