Skip to content

Conversation

@sakshi-arora1
Copy link
Contributor

  • Adding support to cache fragment initial HTML state.

  • Adding support to cache fragment initial HTML state.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

* Adding support to cache fragment initial HTML state.

* Adding support to cache fragment initial HTML state.
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
page-has-heading-one moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.33%. Comparing base (3285255) to head (0d552d7).
Report is 692 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1508   +/-   ##
=========================================
  Coverage     82.33%   82.33%           
  Complexity      963      963           
=========================================
  Files           107      107           
  Lines          2485     2485           
  Branches        339      339           
=========================================
  Hits           2046     2046           
  Misses          264      264           
  Partials        175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sakshi-arora1 sakshi-arora1 merged commit f001bb0 into master Jan 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants