Skip to content

Added active flag in get command#271

Merged
amolina-adobe merged 12 commits into
developfrom
feat/4873-addActiveFlag
Jul 24, 2025
Merged

Added active flag in get command#271
amolina-adobe merged 12 commits into
developfrom
feat/4873-addActiveFlag

Conversation

@AjazSumaiya
Copy link
Copy Markdown
Contributor

Added --active flag in get command , to retrieve last successfull deployed mesh.

Description

aio api-mesh get should accept --active flag.

Related Issue

Motivation and Context

How Has This Been Tested?

Command Description
image

Default behavior should still work as is

  1. aio api-mesh get : returns mesconfig
image

With --active flag changes

  1. aio api-mesh get --active or aio api-mesh get --a : should return last successful deployed meshConfig
    create a valid mesh -- both should return same meshCOnfig if successfully deployed
image image

update with invalid mesh which failed at build -- default should return failed meshConfig and with ---active the valid mesh created should be returned
image
--active
image
Default
image

  1. . aio api-mesh get --active or aio api-mesh get --a : should return no active deployment found
image image

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AjazSumaiya AjazSumaiya requested a review from jhadobe July 18, 2025 11:58
Comment thread src/commands/api-mesh/__tests__/get.test.js Outdated
Comment thread src/commands/api-mesh/__tests__/get.test.js Outdated
Comment thread src/commands/api-mesh/__tests__/get.test.js Outdated
Comment thread src/commands/api-mesh/get.js Outdated
Comment thread src/commands/api-mesh/get.js Outdated
@AjazSumaiya AjazSumaiya marked this pull request as ready for review July 21, 2025 08:08
Comment thread src/lib/smsClient.js Outdated
Comment thread src/lib/smsClient.js Outdated
Comment thread src/lib/smsClient.js Outdated
Comment thread src/commands/api-mesh/__tests__/get.test.js Outdated
Comment thread src/commands/api-mesh/get.js Outdated
Comment thread src/lib/smsClient.js
Comment thread src/commands/api-mesh/__tests__/get.test.js Outdated
Comment thread .github/workflows/build.yml Outdated
amolina-adobe
amolina-adobe previously approved these changes Jul 24, 2025
brasewel
brasewel previously approved these changes Jul 24, 2025
@amolina-adobe amolina-adobe dismissed stale reviews from brasewel and themself July 24, 2025 20:07

The merge-base changed after approval.

@amolina-adobe amolina-adobe merged commit 667e02c into develop Jul 24, 2025
3 checks passed
@amolina-adobe amolina-adobe deleted the feat/4873-addActiveFlag branch July 24, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants