Skip to content

CEXT-6026: Exclude unsafe version of axios#289

Merged
revanth0212 merged 1 commit into
adobe:mainfrom
pdohogne-magento:CEXT-6026-exclude-unsafe-axios
Apr 2, 2026
Merged

CEXT-6026: Exclude unsafe version of axios#289
revanth0212 merged 1 commit into
adobe:mainfrom
pdohogne-magento:CEXT-6026-exclude-unsafe-axios

Conversation

@pdohogne-magento
Copy link
Copy Markdown
Collaborator

Description

Exclude Axios version 1.14.1 and override plain-crypto-js with a local empty package if otherwise found.

Related Issue

CEXT-6026: Update axios dependency to exclude malicious version

Motivation and Context

Axios version 1.14.1 was published with a malicious dependency on plain-crypto-js (see here)

How Has This Been Tested?

Local unit tests via npm test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pdohogne-magento pdohogne-magento force-pushed the CEXT-6026-exclude-unsafe-axios branch from 6e6f86c to 0199327 Compare April 1, 2026 14:46
brasewel
brasewel previously approved these changes Apr 1, 2026
@pdohogne-magento pdohogne-magento changed the base branch from main to develop April 1, 2026 15:11
@pdohogne-magento pdohogne-magento dismissed brasewel’s stale review April 1, 2026 15:11

The base branch was changed.

brasewel
brasewel previously approved these changes Apr 1, 2026
revanth0212
revanth0212 previously approved these changes Apr 1, 2026
@revanth0212
Copy link
Copy Markdown
Contributor

revanth0212 commented Apr 1, 2026

Thanks @pdohogne-magento

What is your opinion on adding min-release-age=7 to the .npmrc file?

This setting will make sure we only prioritize package upgrades after 7 days of their release. This erases 100% of 0 day attacks and 90% of critical security threats. The industry would have figured out the attack and patched it in 7 days.

@pdohogne-magento
Copy link
Copy Markdown
Collaborator Author

pdohogne-magento commented Apr 1, 2026

To keep the PR conversation updated:

Usage of minimum release age is deferred pending further discussion. Considerations:

  • npm does not currently have a way to exclude @adobe/* packages from this rule, though yarn does
  • Minimum release age helps prevent problems/attacks introduced in new dependency versions, but it could also block installing urgent fixes for recently-discovered issues that were introduced in previous versions from before the restriction window.

@pdohogne-magento pdohogne-magento changed the base branch from develop to main April 2, 2026 14:23
@pdohogne-magento pdohogne-magento dismissed stale reviews from revanth0212 and brasewel April 2, 2026 14:23

The base branch was changed.

@revanth0212 revanth0212 merged commit ebe506d into adobe:main Apr 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants