Skip to content

feat: ACNA-2783 - front-end hot reload#15

Merged
shazron merged 13 commits intomainfrom
story/ACNA-2783
Apr 26, 2024
Merged

feat: ACNA-2783 - front-end hot reload#15
shazron merged 13 commits intomainfrom
story/ACNA-2783

Conversation

@shazron
Copy link
Copy Markdown
Member

@shazron shazron commented Apr 17, 2024

This enables front-end hot reload.
This PR incorporates changes from original PR #14 (which has been closed)

How Has This Been Tested?

  • local link of the plugin
  • debug in VS Code of an AB project after running aio app dev init
    1. choose the "Debug" tab in the sidebar
    2. choose the "App Builder: debug full stack" configuration in the Debug dropdown menu
    3. select the green "Play" button
    4. wait for the Chrome browser (required) to launch
    5. edit any Javascript or HTML in the web-src folder
    6. observe the changes reflected in the browser
  • unit tests are expected to fail since we haven't completed unit tests yet

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron changed the title feat: front-end hot reload feat: ACNA-2783 - front-end hot reload Apr 17, 2024
@purplecabbage
Copy link
Copy Markdown
Member

purplecabbage commented Apr 25, 2024

When I run app dev with this, I am forced to choose whether to overwrite, or merge vscode config.

This opens a new window every time ... it should only open a window if --open is true
This only happens when run by vscode launch.

@purplecabbage
Copy link
Copy Markdown
Member

The additions of aio-logger mean that where we used to output

server running on port : 9080
629 static asset(s) changed
✨ Built 3 bundles in 1964ms!

we now output

2024-04-25T00:58:07.400Z [@adobe/aio-cli-plugin-app-dev:bundle-serve] info: server running on port : 9080
⠴ 2024-04-25T00:58:09.506Z [@adobe/aio-cli-plugin-app-dev:bundle-serve] info: 629 static asset(s) changed
2024-04-25T00:58:09.507Z [@adobe/aio-cli-plugin-app-dev:bundle-serve] info: ✨ Built 3 bundles in 1964ms!

This seems to me like a step in the wrong direction.

@purplecabbage
Copy link
Copy Markdown
Member

When I run app dev with this, I am forced to choose whether to overwrite, or merge vscode config. This opens a new window every time ... it should only open a window if --open is true

new chrome window is only when run from vscode-ui, it is the debugWithChrome action so it is probably fine

@shazron
Copy link
Copy Markdown
Member Author

shazron commented Apr 25, 2024

This seems to me like a step in the wrong direction.

It's just a simple change to the logging provider if we want to undo. I thought for debugging it's better to know timestamps of when things happen, especially when hitting your actions, etc.

@shazron
Copy link
Copy Markdown
Member Author

shazron commented Apr 25, 2024

new chrome window is only when run from vscode-ui, it is the debugWithChrome action so it is probably fine

so your comment is resolved?

@shazron
Copy link
Copy Markdown
Member Author

shazron commented Apr 26, 2024

added 15a873c to remove the aio app dev init call at the start of the dev command

@shazron
Copy link
Copy Markdown
Member Author

shazron commented Apr 26, 2024

removed aio app dev init command - existing users can read an upgrade doc 5022877

@shazron
Copy link
Copy Markdown
Member Author

shazron commented Apr 26, 2024

Closed PR #14 in favor of this one.

@shazron shazron merged commit 58e0b80 into main Apr 26, 2024
@shazron shazron deleted the story/ACNA-2783 branch April 26, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants