Skip to content

fix: ACNA-2959, ACNA-2966, ACNA-2784 - creating a standalone app, and running aio app dev, results in an exception. add unit and e2e tests#25

Merged
shazron merged 56 commits intomainfrom
story/ACNA-2959
May 9, 2024
Merged

fix: ACNA-2959, ACNA-2966, ACNA-2784 - creating a standalone app, and running aio app dev, results in an exception. add unit and e2e tests#25
shazron merged 56 commits intomainfrom
story/ACNA-2959

Conversation

@shazron
Copy link
Copy Markdown
Member

@shazron shazron commented Apr 27, 2024

How Has This Been Tested?

  • npm test
  • npm run e2e

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron changed the title fix: ACNA-2959 - creating a standalone app, and running aio app dev, results in an exception fix: ACNA-2959, ACNA-2784 - creating a standalone app, and running aio app dev, results in an exception. add unit tests Apr 29, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@shazron shazron marked this pull request as ready for review May 5, 2024 09:18
@shazron shazron changed the title fix: ACNA-2959, ACNA-2784 - creating a standalone app, and running aio app dev, results in an exception. add unit tests fix: ACNA-2959, ACNA-2966, ACNA-2784 - creating a standalone app, and running aio app dev, results in an exception. add unit tests May 7, 2024
@shazron
Copy link
Copy Markdown
Member Author

shazron commented May 7, 2024

due to the changes for e2e, the unit tests have to be fixed. fixed!

@shazron shazron changed the title fix: ACNA-2959, ACNA-2966, ACNA-2784 - creating a standalone app, and running aio app dev, results in an exception. add unit tests fix: ACNA-2959, ACNA-2966, ACNA-2784 - creating a standalone app, and running aio app dev, results in an exception. add unit and e2e tests May 7, 2024
Comment thread test/lib/constants.test.js
Comment thread test/jest.setup.js Outdated
Comment thread test/jest.setup.js Outdated
Comment thread test/commands/app/dev/index.test.js Outdated
Comment thread test/commands/app/dev/index.test.js Outdated
Comment thread test/lib/run-dev.test.js
Comment thread e2e/test-project/src/dx-excshell-1/actions/noMainExport/index.js
Comment thread src/BaseCommand.js Outdated
@shazron shazron merged commit 233ef5a into main May 9, 2024
@shazron shazron deleted the story/ACNA-2959 branch May 9, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants