Skip to content

fix: ACNA-2988, ACNA-2987 - npm run e2e fixes for Windows#40

Merged
shazron merged 3 commits intomainfrom
story/ACNA-2988
May 23, 2024
Merged

fix: ACNA-2988, ACNA-2987 - npm run e2e fixes for Windows#40
shazron merged 3 commits intomainfrom
story/ACNA-2988

Conversation

@shazron
Copy link
Copy Markdown
Member

@shazron shazron commented May 18, 2024

fixes #37
fixes #38

How Has This Been Tested?

  • npm test
  • npm run e2e on Windows (with no orphaned processes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ca7f27e) to head (fc10b0d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          513       513           
  Branches       107       107           
=========================================
  Hits           513       513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron shazron merged commit 6d62320 into main May 23, 2024
@shazron shazron deleted the story/ACNA-2988 branch May 23, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: npm run e2e does not properly clean up resources Windows: npm run e2e does not work

3 participants