fix: remove return value from fingerprint command#84
Conversation
Commands should not return values; output is already logged via this.log(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR adjusts the aio certificate fingerprint oclif command behavior by removing its resolved return value, relying solely on this.log() output.
Changes:
- Removed the
return res.certificateFingerprintfromFingerprintCommand.run().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🤖 PR Reviewer
The diff removes the return value from FingerprintCommand.run() and updates the test to verify behavior via a log spy instead. This is a clean, intentional change that aligns with the CLI command pattern where run() need not return meaningful values. The test update correctly verifies both the undefined resolution and that logging occurred with the expected fingerprint.
✅ LGTM! This PR looks good to merge.
💡 How to re-trigger
Comment /review or /pr-reviewer on this PR
Fixes #83
Summary
return res.certificateFingerprintfrom thefingerprintcommand'srun()methodthis.log()Test plan
aio certificate fingerprint <cert-file>and verify the fingerprint is still printed to stdout🤖 Generated with Claude Code