Skip to content

fix: remove return value from fingerprint command#84

Merged
shazron merged 3 commits into
masterfrom
fix/fingerprint-no-return
Apr 27, 2026
Merged

fix: remove return value from fingerprint command#84
shazron merged 3 commits into
masterfrom
fix/fingerprint-no-return

Conversation

@shazron
Copy link
Copy Markdown
Member

@shazron shazron commented Apr 13, 2026

Fixes #83

Summary

  • Removes the return res.certificateFingerprint from the fingerprint command's run() method
  • oclif commands should not return values; output is already logged via this.log()

Test plan

  • Run aio certificate fingerprint <cert-file> and verify the fingerprint is still printed to stdout
  • Verify no regression in other certificate commands

🤖 Generated with Claude Code

Commands should not return values; output is already logged via this.log().

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the aio certificate fingerprint oclif command behavior by removing its resolved return value, relying solely on this.log() output.

Changes:

  • Removed the return res.certificateFingerprint from FingerprintCommand.run().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/commands/certificate/fingerprint.js
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 PR Reviewer

The diff removes the return value from FingerprintCommand.run() and updates the test to verify behavior via a log spy instead. This is a clean, intentional change that aligns with the CLI command pattern where run() need not return meaningful values. The test update correctly verifies both the undefined resolution and that logging occurred with the expected fingerprint.

LGTM! This PR looks good to merge.


💡 How to re-trigger

Comment /review or /pr-reviewer on this PR

@shazron shazron merged commit 286904d into master Apr 27, 2026
11 checks passed
@shazron shazron deleted the fix/fingerprint-no-return branch April 27, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aio certificate fingerprint error

4 participants