Skip to content

Conversation

@justinedelson
Copy link
Member

Description

Correctly pass this to hooks from prerun hook

Related Issue

#295

Motivation and Context

Bug fix

How Has This Been Tested?

Unit test
Manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #297 (127d77c) into main (aa14ecf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          46       46           
  Lines        1062     1062           
  Branches      118      118           
=======================================
  Hits         1060     1060           
  Misses          1        1           
  Partials        1        1           
Impacted Files Coverage Δ
src/hooks/prerun/prerun-all.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa14ecf...127d77c. Read the comment docs.

@justinedelson justinedelson force-pushed the issue/fix-ims-context-check branch from 5f2a546 to 127d77c Compare April 29, 2021 16:51
@justinedelson justinedelson merged commit f2a5768 into main Apr 29, 2021
github-actions bot pushed a commit that referenced this pull request Apr 29, 2021
## [1.6.1](1.6.0...1.6.1) (2021-04-29)

### Bug Fixes

* **hook:** check-ims-config is not correctly throwing errors. fixes [#295](#295) ([#297](#297)) ([f2a5768](f2a5768))
@github-actions
Copy link

🎉 This PR is included in version 1.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants