Skip to content

fix: ACNA-2799 - code links in README point to a .ts file#151

Merged
shazron merged 2 commits intomasterfrom
story/ACNA-2799
Feb 6, 2024
Merged

fix: ACNA-2799 - code links in README point to a .ts file#151
shazron merged 2 commits intomasterfrom
story/ACNA-2799

Conversation

@shazron
Copy link
Copy Markdown
Member

@shazron shazron commented Feb 2, 2024

closes #150

How Has This Been Tested?

  1. rm -rf node_modules
  2. npm i
  3. npm test
  4. npm run prepack
  5. Inspect README.md for See code: links (should point to the .js file)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b8d44c) 100.00% compared to head (832e1ea) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #151   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          153       153           
  Branches        36        36           
=========================================
  Hits           153       153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron shazron merged commit 5075399 into master Feb 6, 2024
@shazron shazron deleted the story/ACNA-2799 branch February 6, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

config plugin: code links in README point to a .ts file

2 participants