Tweak missing property messages to improve clarity#107
Merged
purplecabbage merged 1 commit intoadobe:masterfrom Feb 5, 2020
Merged
Tweak missing property messages to improve clarity#107purplecabbage merged 1 commit intoadobe:masterfrom
purplecabbage merged 1 commit intoadobe:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 57 57
Lines 1737 1737
Branches 302 302
=====================================
Hits 1737 1737
Continue to review full report at Codecov.
|
10 tasks
bhageena
pushed a commit
to bhageena/aio-cli-plugin-runtime
that referenced
this pull request
Jul 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hey! Still learning I/O ins and outs, and went to copy some config in
manifest.ymlto create a second function for my application.Unfortunately I missed some fields, specifically the
runtimefield. The following error message was flushed when runningaio app deploy:When I read this message, I was thinking of
runtimemore as an Adobe concept, and it didn't immediately occur to me thatruntimewas a property name.Tweaked two error messages to (hopefully) add some clarity.
Related Issue
Motivation and Context
Easier onboarding for new folks
How Has This Been Tested?
Functionality is already covered by unit tests, just updated the error string we're asserting on
Screenshots (if appropriate):
Types of changes
Checklist: