Support deploying of blackbox actions#129
Merged
purplecabbage merged 4 commits intoadobe:masterfrom Feb 27, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 57 57
Lines 1776 1776
Branches 319 319
=====================================
Hits 1776 1776
Continue to review full report at Codecov.
|
10 tasks
bhageena
pushed a commit
to bhageena/aio-cli-plugin-runtime
that referenced
this pull request
Jul 21, 2021
* support blackbox images * fix existing test cases * add unit test for blackbox action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
dockerfield inmanifest.ymlis currently ignored. It is needed for deploying blackbox actions. This change sets the right values for theopenwhiskcreate action call.blackboxifdockeris setimageto value ofdockersequencetype check (now that there is ablackboxkind`Related Issue
#128
Motivation and Context
This is required for Nui.
How Has This Been Tested?
Unit tests. Manual test deployed against actual openwhisk.
Screenshots (if appropriate):
n/a
Types of changes
Checklist:
docker: https://github.com/apache/openwhisk-wskdeploy/blob/master/specification/html/spec_actions.md#fields