harden implementation of require-adobe-auth annotation#139
Merged
moritzraho merged 2 commits intoadobe:masterfrom Mar 20, 2020
Merged
harden implementation of require-adobe-auth annotation#139moritzraho merged 2 commits intoadobe:masterfrom
moritzraho merged 2 commits intoadobe:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 1809 1821 +12
Branches 326 330 +4
=========================================
+ Hits 1809 1821 +12
Continue to review full report at Codecov.
|
10 tasks
10 tasks
purplecabbage
approved these changes
Mar 19, 2020
bhageena
pushed a commit
to bhageena/aio-cli-plugin-runtime
that referenced
this pull request
Jul 21, 2021
* fix secured action by making it non web and support raw-httpt * only parse annotation for I/O Runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adobeioruntime.net. The current implementation will break other openwhisk deployments such as in a local dev stack. This is because the validation action /adobeio/shared-validators/ims is only available in Adobe I/O RuntimeTypes of changes
Checklist: