Skip to content

harden implementation of require-adobe-auth annotation#139

Merged
moritzraho merged 2 commits intoadobe:masterfrom
moritzraho:fixes-adobe-auth
Mar 20, 2020
Merged

harden implementation of require-adobe-auth annotation#139
moritzraho merged 2 commits intoadobe:masterfrom
moritzraho:fixes-adobe-auth

Conversation

@moritzraho
Copy link
Copy Markdown
Member

@moritzraho moritzraho commented Mar 18, 2020

Description

  • secure original action by making them non web instead of using require-whisk-auth (which allowed every valid namespace to access the action!)
  • support for raw-http actions
  • only rewrite actions when the apihost is adobeioruntime.net. The current implementation will break other openwhisk deployments such as in a local dev stack. This is because the validation action /adobeio/shared-validators/ims is only available in Adobe I/O Runtime

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2020

Codecov Report

Merging #139 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #139   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         1809      1821   +12     
  Branches       326       330    +4     
=========================================
+ Hits          1809      1821   +12     
Impacted Files Coverage Δ
src/RuntimeBaseCommand.js 100.00% <100.00%> (ø)
src/commands/runtime/deploy/index.js 100.00% <100.00%> (ø)
src/commands/runtime/deploy/sync.js 100.00% <100.00%> (ø)
src/commands/runtime/deploy/undeploy.js 100.00% <100.00%> (ø)
src/runtime-helpers.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 539a1de...e9c6b54. Read the comment docs.

@moritzraho moritzraho marked this pull request as ready for review March 19, 2020 10:12
@moritzraho moritzraho merged commit f5dec42 into adobe:master Mar 20, 2020
@moritzraho moritzraho deleted the fixes-adobe-auth branch March 20, 2020 07:57
bhageena pushed a commit to bhageena/aio-cli-plugin-runtime that referenced this pull request Jul 21, 2021
* fix secured action by making it non web and support raw-httpt

* only parse annotation for I/O Runtime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants