Skip to content

support for ${*} syntax in manifest#144

Merged
moritzraho merged 1 commit intomasterfrom
env-param
Apr 14, 2020
Merged

support for ${*} syntax in manifest#144
moritzraho merged 1 commit intomasterfrom
env-param

Conversation

@Himavanth
Copy link
Copy Markdown
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2020

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #144   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         1823      1824    +1     
  Branches       331       332    +1     
=========================================
+ Hits          1823      1824    +1     
Impacted Files Coverage Δ
src/runtime-helpers.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f098725...9bf7e25. Read the comment docs.

@meryllblanchet meryllblanchet added the bug Something isn't working label Apr 14, 2020
@moritzraho
Copy link
Copy Markdown
Member

lgtm

@moritzraho moritzraho merged commit d9fa0fb into master Apr 14, 2020
@Himavanth Himavanth deleted the env-param branch April 14, 2020 13:12
@purplecabbage
Copy link
Copy Markdown
Member

This needs a new fixture and new test. It has effectively stopped testing for $ENV and now ONLY tests for ${ENV}

@moritzraho
Copy link
Copy Markdown
Member

oops +1 thanks for double checking, thought there was a another fixture somewhere that was also checking for $. But even tho we should make the intent of the fixture clear

bhageena pushed a commit to bhageena/aio-cli-plugin-runtime that referenced this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants