Skip to content

When kind cannot be determined, throw error.#149

Merged
purplecabbage merged 2 commits intoadobe:masterfrom
rabbah:undefkind
Apr 20, 2020
Merged

When kind cannot be determined, throw error.#149
purplecabbage merged 2 commits intoadobe:masterfrom
rabbah:undefkind

Conversation

@rabbah
Copy link
Copy Markdown
Contributor

@rabbah rabbah commented Apr 16, 2020

Description

Checks if the action kind could not be determined and throws error when necessary.

Related Issue

Fixes #148.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2020

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #149   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         1824      1827    +3     
  Branches       332       333    +1     
=========================================
+ Hits          1824      1827    +3     
Impacted Files Coverage Δ
src/commands/runtime/action/create.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b8717b...12d899e. Read the comment docs.

@meryllblanchet meryllblanchet added the bug Something isn't working label Apr 20, 2020
@purplecabbage purplecabbage merged commit c6d9672 into adobe:master Apr 20, 2020
@rabbah rabbah deleted the undefkind branch January 25, 2021 17:29
bhageena pushed a commit to bhageena/aio-cli-plugin-runtime that referenced this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

action exec posted with no kind

3 participants