#154 - AIO-CLI cannot deploy APIs under the same <base path>#156
Merged
purplecabbage merged 14 commits intoadobe:masterfrom Apr 28, 2020
Merged
#154 - AIO-CLI cannot deploy APIs under the same <base path>#156purplecabbage merged 14 commits intoadobe:masterfrom
purplecabbage merged 14 commits intoadobe:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 1827 1830 +3
Branches 333 333
=========================================
+ Hits 1827 1830 +3
Continue to review full report at Codecov.
|
ekremney
approved these changes
Apr 23, 2020
basecode
reviewed
Apr 23, 2020
meryllblanchet
requested review from
sandeep-paliwal
and removed request for
purplecabbage
Contributor
|
@solaris007 These changes will affect aio app deploy/undeploy usecases. Can you confirm that the action/apis deployment/undeploy for apps works fine. I will also try to give it a try locally. |
Member
Author
|
@sandeep-paliwal as mentioned in the PR, i wrote a test case, but more imporantly deployed our whole project suffering from this issue with a self-built aio-cli - it deploys and undeploys as expected on AIO |
Member
Author
|
@sandeep-paliwal all done |
bhageena
pushed a commit
to bhageena/aio-cli-plugin-runtime
that referenced
this pull request
Jul 21, 2021
…obe#156) * multi actions per resource * naming and use push instead of concat * more verbose log output * fix undefined on log operations * optimize logging * rename to API route
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjust
processPackageto correctly provide all routes defined within a manifest'sapisection, including multiple actions per resource definition.Related Issue
#154
Motivation and Context
Change is necessary due to the bug described in #154
How Has This Been Tested?
Added test case for multi-action resource API.
Released internal aio-cli and deployed our project with it.
Types of changes
Checklist: