Skip to content

Fix trigger fire parameters.#231

Merged
Himavanth merged 1 commit intoadobe:masterfrom
rabbah:trigger
Apr 22, 2021
Merged

Fix trigger fire parameters.#231
Himavanth merged 1 commit intoadobe:masterfrom
rabbah:trigger

Conversation

@rabbah
Copy link
Copy Markdown
Contributor

@rabbah rabbah commented Apr 12, 2021

Description

See #230.

Related Issue

Closes #230.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2021

Codecov Report

Merging #231 (da366ce) into master (156cc02) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         1493      1489    -4     
  Branches       287       285    -2     
=========================================
- Hits          1493      1489    -4     
Impacted Files Coverage Δ
src/commands/runtime/action/invoke.js 100.00% <100.00%> (ø)
src/commands/runtime/trigger/fire.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 156cc02...da366ce. Read the comment docs.

@meryllblanchet meryllblanchet requested review from Himavanth and purplecabbage and removed request for purplecabbage April 12, 2021 12:39
@meryllblanchet
Copy link
Copy Markdown

Thanks for the quick PR @rabbah !
@Himavanth @purplecabbage could you have a look?

@Himavanth
Copy link
Copy Markdown
Contributor

LGTM. I just hope there are no automated CLI scripts relying on the previous erroneous implementation. Would be a rare case though. @purplecabbage ?

@meryllblanchet meryllblanchet mentioned this pull request Apr 22, 2021
10 tasks
@Himavanth Himavanth merged commit 2319ae9 into adobe:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

passing parameters with triggers is not the same as action (but should be)

3 participants