Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 1493 1489 -4
Branches 287 285 -2
=========================================
- Hits 1493 1489 -4
Continue to review full report at Codecov.
|
|
Thanks for the quick PR @rabbah ! |
Contributor
|
LGTM. I just hope there are no automated CLI scripts relying on the previous erroneous implementation. Would be a rare case though. @purplecabbage ? |
Himavanth
approved these changes
Apr 14, 2021
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #230.
Related Issue
Closes #230.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: