Conversation
|
@meryllblanchet Could you check the text change ? |
| limit: flags.integer({ | ||
| char: 'l', | ||
| description: `only return LIMIT number of activations from the collection with a maximum LIMIT of ${ActivationList.limits.max} activations (default 30)` | ||
| description: `only return LIMIT number of activations (maximum ${ActivationList.limits.max}). Note that the maximum could be set to a lesser value by the server` |
There was a problem hiding this comment.
What about Note that the maximum set for I/O Runtime is 50 ?
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 58 58
Lines 1565 1565
Branches 308 308
=========================================
Hits 1565 1565
Continue to review full report at Codecov.
|
| limit: flags.integer({ | ||
| char: 'l', | ||
| description: `only return LIMIT number of activations from the collection with a maximum LIMIT of ${ActivationList.limits.max} activations (default 30)` | ||
| description: `only return LIMIT number of activations (maximum ${ActivationList.limits.max}). Note that the maximum set for Adobe I/O Runtime is 50` |
There was a problem hiding this comment.
Do you have to repeat this message on al the list commands?
if the Max constant already says 50, do you need the second Adobe/IO part :)
|
On second thought, since these limits are set by the server and there is no way for the CLI to know the limits in advance, I think the CLI should refrain from saying anything about the limits and just pass it on. |
|
Makes sense, what description would you then propose for the CLI listing commands? |
|
I would propose to keep the existing text after removing the absolute numbers for the limits. |
Description
Fixes #229
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: